validator icon indicating copy to clipboard operation
validator copied to clipboard
verified publisher icon go-playground

feat(BREAKING): Change CIDRIPv4 validation

Open martinlehoux opened this issue 3 years ago • 2 comments

Summary

  • Mentions #909
  • Disable validation of cidripv4 when ip is not the begining of the block
  • My linter just added some go fmt I guess

Fixes Or Enhances

  • [x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

martinlehoux avatar May 14 '22 19:05 martinlehoux

Coverage Status

coverage: 73.849%. remained the same when pulling 95c81e616d494d753137699c267810162d89b6fe on martinlehoux:master into 8d50f2fd8c2f02fbdf1d44d66171b955c2f4eb50 on go-playground:master.

coveralls avatar May 14 '22 19:05 coveralls

Hi @deankarn , is there anything I can do to push this forward?

martinlehoux avatar Oct 13 '22 06:10 martinlehoux

Hi @deankarn is there anyway to have a status on this one? So I know if I take the time to rebase, or if this change is not useful

martinlehoux avatar Sep 30 '23 16:09 martinlehoux

Hey @martinlehoux sorry for letting this one slip through the cracks.

yes I will try to merge tomorrow.

deankarn avatar Oct 01 '23 03:10 deankarn