validator icon indicating copy to clipboard operation
validator copied to clipboard
verified publisher icon go-playground

add domain validation(simple domain names)

Open aryehlev opened this issue 3 years ago • 1 comments

Fixes Or Enhances

Make sure that you've checked the boxes below before you submit PR:

  • [x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

aryehlev avatar Sep 14 '22 16:09 aryehlev

Coverage Status

Coverage increased (+0.005%) to 74.188% when pulling 7b7e3b3840ec098e1d004379861d0f1626f62e19 on aryehlev:master into c7e0172e0fd176bdc521afb5186818a7db6b77ac on go-playground:master.

coveralls avatar Sep 14 '22 16:09 coveralls

@aryehlev I'm hesitant to merge this only because full domain validation is much more complicated than this and don't want to give users a false sense of security.

if a more comprehensive validation can be added I'd be happy to merge.

deankarn avatar Mar 19 '23 20:03 deankarn

This is the validation I use since I'd rather let some false negatives than false positives. But I will try to research a more comprehensive validation and if I don't find one I will close this pr. Thank you🙏

aryehlev avatar Mar 19 '23 20:03 aryehlev