validator icon indicating copy to clipboard operation
validator copied to clipboard
verified publisher icon go-playground

MongoDB validator improved

Open pixel365 opened this issue 2 years ago • 3 comments

Enhances

Added MongoDB connection string validation

Make sure that you've checked the boxes below before you submit PR:

  • [x] Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

pixel365 avatar Nov 15 '23 13:11 pixel365

Coverage Status

coverage: 74.179% (+0.3%) from 73.903% when pulling 99a8d67eba5561ddc1a5dc9afd3b0413f9582185 on pixel365:mongodb into 84254aeb5a59e615ec0b66ab53b988bc0677f55e on go-playground:master.

coveralls avatar Nov 15 '23 13:11 coveralls

I'm not sure it would be best to have one validation do two different things, otherwise you wouldn't be able to differentiate for error messages and alike what exactly failed.

deankarn avatar Jan 14 '24 04:01 deankarn

I'm not sure it would be best to have one validation do two different things, otherwise you wouldn't be able to differentiate for error messages and alike what exactly failed.

I agree with this remark. Added a separate tag.

pixel365 avatar Jan 15 '24 09:01 pixel365

@deankarn Hi, how about this pull request?

pixel365 avatar May 31 '24 14:05 pixel365