Denis DelGrosso comments

Results 139 comments of


                                            Denis DelGrosso

Memory leak in createReadStream when destroy() is called on resulting stream and validation is set to true

@jpambrun I know this issue is old and closed for over a year but please see: https://github.com/googleapis/nodejs-storage/issues/2313. I think this may have been the same issue.

Supplying a complex object (i.e. buffer) as an argument to md5Hash or crc32c does not invoke server validation

Re-visiting this today I took a look at the [JSON docs](https://cloud.google.com/storage/docs/json_api/v1/objects#resource). Both MD5 and CRC32C are defined as strings. As such I do not think the library should handle the...

Support batch requests

The current guidance for bulk deletions is to leverage [OLM](https://cloud.google.com/storage/docs/lifecycle). Further additions for batch operations are unlikely to be implemented and as such I am going to close this issue.

Add support for custom backoff

Thanks @camflan, apologies on the delay. Will get this merged today. Can you run `npm run fix` to fix the linter issues?

Add support for custom backoff

Thanks again for the contribution @camflan!

feat: implement parallel operations

Since this is getting large and most feedback has been addressed going to go ahead and merge this into the staging branch. We can re-review before the final merge to...

storage: "before all" hook in "storage" failed

Per the internal tracking ticket this is likely due to network issues and not because of any underlying problem. The recommendation is to roll retries at our level around the...

Stronger typing for LifecycleRule conditions

Released with 7.0.

Upgrade node-fetch dependency to v3.2

Hi @adarshmadrecha thanks for opening this issue. Currently we are unable to update to node-fetch 3.x as it has moved to a pure ESM package. Please see https://github.com/googleapis/gaxios/issues/429 for additional...

Add a permission sample to the Drive V3 samples

Hi @justinszaro we would certainly welcome the contribution if you wish to write a sample.