Denis DelGrosso

Results 139 comments of Denis DelGrosso

@drichardson thanks for the heads up. I will poke around in entities to see if it meets our needs.

@cfdavidpetter this issue for removing `ent` which has not been done. If you are having another issue please feel free to open a new one.

Thanks @cfdavidpetter we are aware of the deprecation of `punycode` and plan to remove `ent` in the next major version of the storage library.

Thanks @danielbankhead this is probably a good stop gap before next major version where I hope to remove the dependency altogether.

https://github.com/googleapis/nodejs-storage/pull/2451

`Ent` has been replaced with `html-entities` for the time being. I still intend to remove this functionality in the next major version. Going to update the title of this issue...

Updating this as a self reminder of sorts: this appears to [have been fixed](https://github.com/node-fetch/node-fetch/releases/tag/v3.1.1) in `node-fetch v3.1.1` . It does not appear that the fix was ever back ported to...

Possibly related as well: https://github.com/node-fetch/node-fetch/pull/1064. This appears to have been backported and released with 2.6.9. We moved to an async iterator with this PR: https://github.com/googleapis/nodejs-storage/pull/1925 this was around the same...

To my last comment, I was able to verify hanging behavior with `2.6.7` but get a correct error with `2.6.9` of node-fetch.

```typescript import express from 'express'; import fetch from 'node-fetch'; const app = express(); const port = 5000; let count = 0; app.get('/', (req, res) => { setInterval(() => { count++;...