Denis DelGrosso
Denis DelGrosso
See my original note https://github.com/googleapis/nodejs-storage/issues/1824#issuecomment-1091921411. Is this encoding causing an issue or is it just a readability problem as noted in this issue?
Being as this appears to be working as intended. Going to close this issue out. If there are any other questions or concerns, please feel free to reopen / open...
Let me take another look and see if I can improve on what was done.
Just some notes from poking around at this a bit, as noted the library currently encodes `/` which it should not be doing. However, `/` isn't a valid value in...
@ryanwilsonperkin @danielbankhead it sounds like this has been resolved?
@scotthart is this something we should point at your 'prepare for 3.x' branch?
Repointing this at the prepare-3.0 branch.
@shubham-up-47 since these deprecation notices will go into the 3.x release, I think we need to update the messages to say they will be removed in 4.x. We can't remove...
@sydney-munro we want to add these to the storage client? The PR for storage control contains samples, etc... https://github.com/googleapis/google-cloud-node/pull/5154. Seems confusing to add instructions on using a different library in...
The installation instructions for this library live in the `README.md`: https://github.com/googleapis/nodejs-storage?tab=readme-ov-file#installing-the-client-library. Perhaps we could add a new section in the `README.md` that says something along the lines that if a...