Dylan Hyun

Results 12 comments of Dylan Hyun

> > I realize you have a pending question, but if that the response doesn't block this merge, everything else looks good. > > @dchyun do you think we should...

> This looks good, but we should definitely test this in products before we ship. Last year we changed something similar-ish in Dropdown and it broke tests (and led us...

Converted back to a draft pr until [issues with failing tests](https://github.com/hashicorp/design-system/pull/2643#discussion_r1917566826) in consumer's repos can be sorted.

@lane-wetmore was trying to resolve the conflicts that have come up, and I see in a [recent commit](https://github.com/hashicorp/vault/commit/be9111a67777bbd8a1bb3d3c41ce2ee613764101) it seems`GENERAL.toggleGroup()` is being replaced with `GENERAL.button()`. Would that be applicable here...

@lane-wetmore would you be able to re-review this? All feedback has been addressed and conflicts resolved. There is one linting error which is unrelated to this PR and seems to...

> A few thing that I've noticed in the showcase of this PR, and I don't see in the "production" showcase: @didoo Thanks for catching those. The line highlight issues...

> > A few thing that I've noticed in the showcase of this PR, and I don't see in the "production" showcase: > > @didoo Thanks for catching those. The...

> > Suggestion: It would be nice to make the shadow not overlap the scrollbar. Advanced Table does it for the scroll indicators.. since youre already getting dimensions of the...

> @dchyun Thanks, was there a reason to change it before? @KristinLBradley the original approach was causing issues with the line highlighting that Prism.js needed to apply.

> @KristinLBradley Not to throw another option in the ring - but the way the advanced table shadows work is that they are a sibling of the grid and then...