vault icon indicating copy to clipboard operation
vault copied to clipboard

[VAULT-34733] UI: Move the `textarea` block in `FormField` under the HDS block

Open dchyun opened this issue 7 months ago • 2 comments

[!IMPORTANT] DO NOT MERGE UNTIL 1.20 branch cut.

Description

What does this PR do?

  • Updated logic in isHdsFormField of FormField to include the textarea use case
  • Moved template logic for textarea in FormField under the isHdsField block
  • Updated FormField tests for the textarea use case, and updated other failing tests from the conversion to HDS

Note: This has been added under the 1.20 milestone, but will be held until the 1.21 milestone (which has yet to be created).

External links

Screenshots

Before Screenshot 2025-05-27 at 11 34 13 AM

After Screenshot 2025-05-27 at 11 33 13 AM

TODO only if you're a HashiCorp employee

  • [ ] Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • [ ] LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • [ ] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature of a public function, even if that change is in a CE file, double check that applying the patch for this PR to the ENT repo and running tests doesn't break any tests. Sometimes ENT only tests rely on public functions in CE files.
  • [x] Jira: If this change has an associated Jira, it's referenced either in the PR description, commit message, or branch name.
  • [ ] RFC: If this change has an associated RFC, please link it in the description.
  • [ ] ENT PR: If this change has an associated ENT PR, please link it in the description. Also, make sure the changelog is in this PR, not in your ENT PR.

dchyun avatar May 27 '25 15:05 dchyun

CI Results: All Go tests succeeded! :white_check_mark:

github-actions[bot] avatar May 27 '25 16:05 github-actions[bot]

Build Results: All builds succeeded! :white_check_mark:

github-actions[bot] avatar May 28 '25 14:05 github-actions[bot]

@lane-wetmore was trying to resolve the conflicts that have come up, and I see in a recent commit it seemsGENERAL.toggleGroup() is being replaced with GENERAL.button(). Would that be applicable here as well? Should I update the test I just changed to toggleGroup to use button?

Update: Saw that the tests were failing with toggleGroup so left everything as GENERAL.button

dchyun avatar Jun 18 '25 13:06 dchyun

@lane-wetmore would you be able to re-review this? All feedback has been addressed and conflicts resolved. There is one linting error which is unrelated to this PR and seems to be present on all open UI prs at the moment.

dchyun avatar Jun 25 '25 17:06 dchyun