Daco Harkes

Results 574 comments of Daco Harkes

> It would be nice if this was not a Flutter specific API Hot restart is a Flutter concept, not a Dart concept. Dart only has hot-reload. And hot reload...

> * We need to make sure that `NativeFinalizer` behaves as documented in situations when Flutter is shutting down isolates for hot restart. If it does not - we need...

> Callbacks will happen as early as possible, when the object becomes inaccessible to the program, and may happen at any moment during execution of the program. **At the latest,...

> The gist of the problem is the following: isolate shutdown can only safely proceed when it knows that `cb` is unregistered from the producer _and_ that there is no...

If we want to support deleting native callables from native finalizers via a native API (https://github.com/dart-lang/sdk/issues/61887) and deleting persistent handles from native finalizers, it would also be beneficial to delay...

Ah you came up with an idea to achieve this! I was also thinking that instead of `validateCodeAssetBuildOutput` in the PR, we could have `CodeAsset.validateBuildOutput` (static method). Doing that for...

> * Users are not expected to execute these hooks themselves I believe when the output is erroneous, the easiest way for users to triage the errors is to step...

We cannot have validation for temporary asset types (that only live between build and link) in embedders, because embedders don't know about those. So if we want to support validation...

> As some hooks may depend on the contents of a directory (e.g. add all fonts of a directory), we may need to add a concept of `output.addDirectoryDependency({bool recursive})` to...

Yeah, I pondered this question when we first started this project. And, I still don't know a good solution. 🙃