Daco Harkes
Daco Harkes
> Is this test https://github.com/flutter/flutter/blob/4342887826c24197d66192a2733bc2fbf968aa85/packages/flutter_tools/test/integration.shard/isolated/native_assets_test.dart or https://github.com/flutter/flutter/blob/4342887826c24197d66192a2733bc2fbf968aa85/dev/devicelab/lib/tasks/native_assets_test.dart The second: ``` Executing "C:\opt\s\w\ir\x\w\rc\tmpc0tb3lnf\flutter sdk\bin\cache\dart-sdk\bin\dart --enable-vm-service=0 --no-pause-isolates-on-exit bin/tasks/native_assets_android.dart" in "C:\opt\s\w\ir\x\w\rc\tmpc0tb3lnf\flutter sdk\dev\devicelab" with environment {BOT: true, LANG: en_US.UTF-8} ```
The previous instantiation of flakiness: * https://github.com/flutter/flutter/issues/146236
Maybe it's one of the other memory flags: Googling around I found another one. I've created a PR: * https://github.com/flutter/flutter/pull/156201 I don't really have an idea what else to try,...
SGTM! Do we need an integration test for this? (Where would we download from though?)
Another way to test it would be make a hook that simply fails if some env var is filtered out. And then we pass in the vars in a test...
I believe this is a similar ask as: * https://github.com/dart-lang/native/issues/2480 And another use case for the > Option 5: Pre-build-hook which would enable scripting user-defines.
> It looks like the failing health checks may be an analyzer issue? Or at least I don't understand how these changes could cause the error from the logs. I...
> I believe the Linux tests are failing here because we arbitrarily pick one tool out of the list returned (`CompilerResolver._tryLoadToolFromNativeToolchain` picks the first). So now that we find additional...
Closing stale PRs, please reopen if still relevant.
Bump package hooks to `0.19.1-wip`.