Daco Harkes

Results 140 issues of Daco Harkes

Currently, when doc comments contain code snippets with the following, ```dart ///```dart ///``` ``` all of our tooling supports this. However, when using the following, the VS Code highlighter doesn't...

docs-api
area-documentation

``` dart class Scene extends NativeFieldWrapperClass1 { @FfiNative('Scene::dispose') external void dispose(); } ``` `NativeFieldWrapperClass`es often share their identity between Dart and C++. The first, and in this case only native...

area-vm
library-ffi

Adds documentation from the questions answered in: * https://github.com/flutter/flutter/issues/108974 ## Presubmit checklist - [x] This PR doesn’t contain automatically generated corrections (Grammarly or similar). - [x] This PR follows the...

https://github.com/dart-lang/tflite_native/commit/ee967831628b6cf9c239a0d19a5691264060cd4a updated the windows dll, but it does not contain any symbols (verified with Dependency Walker). The dll before that commit does contain symbols. I uncovered this by pulling in...

We guarantee to run all native finalizers before VM-shutdown completes. We do not guarantee to run all native finalizers before an isolate shuts down. Should hot-restart have the VM-shutdown semantics?...

area-vm
vm-gc

``` Running "out/DebugX64/gen_snapshot --snapshot-kind=app-aot-elf --elf=/b/s/w/it67tm0dq9/AMVPQZ/app.elf --no-sound-null-safety runtime/tests/concurrency/generated_stress_test.dart.aot.dill" [0:08:00.002260] ... still working ... [0:12:00.002226] ... still working ... [0:16:00.002213] ... still working ... [0:20:00.002286] ... still working ... [0:24:00.002276] ... still...

area-vm
gardening

The following snippet throws an error instead of returning an error object: ```c++ Dart_Handle DartRuntimeHooks::GetCallbackFromHandle(int64_t handle) { Dart_Handle result = DartCallbackCache::GetCallback(handle); if (Dart_IsError(result)) { Dart_PropagateError(result); } return result; } ```...

area-vm
library-ffi

There are new test failures on [[vm] Record field access operations...[dart2wasm] Trivial test for subtype of Object](https://github.com/dart-lang/sdk/compare/82f163fa4f6ddcf922b3e9fed038968b92d8c0f6~...e36a39437c9f3370528f578942aa22e732faad25). The tests ``` vm/dart_2/isolates/thread_pool_test Crash (expected Pass) ``` are failing on configurations ```...

area-vm
gardening

The analyzer reports an error on the following two cases. ```dart /// Subtracts 2 integers. @ffi.FfiNative('subtract') external int subtract( ffi.Pointer a, int b, ); /// Divides 2 floats, returns a...

area-analyzer
P3
library-ffi

We have no test catching * https://github.com/flutter/flutter/issues/115347 Rather than add a specific test for that, we should add a test that does it for all templates (and all lints/warnings/errors).

a: tests
easy fix
tool
a: first hour
proposal
P4