Daco Harkes

Results 574 comments of Daco Harkes

This needs to be implemented in `package:coverage` first: * https://github.com/dart-lang/tools/issues/2083

cc @mosuem Are you using these functions? (The initial one was added by you.) Context: I'm trying to see 1. what classes we typically need inside hooks, 2. what classes...

> @dcharkes `et` workflows should do the right thing automatically. Hm, in that case we should detect third_party/dart is a different checkout? than what DEPS specifies? E.g. using `git` commands...

👍 To the above. Somewhat related: If the variability per OS is mappable to one type, we could generate ABI specific types. We already support that for integers, but not...

```dart final buildConfig = BuildConfig.build( outputDirectory: outputDirectory, packageName: await _packageName(), packageRoot: Directory.current.uri, buildMode: buildMode ?? BuildMode.release, targetArchitecture: targetArchitecture ?? Architecture.current, targetOS: targetOS ?? OS.current, linkModePreference: linkModePreference ?? LinkModePreference.dynamic, linkingEnabled: linkingEnabled...

Duplicate: https://github.com/dart-lang/dart_style/issues/1531

`await`s are fixed as of https://github.com/dart-lang/dart_style/pull/1538 ❤️ `as` expressions are not block-formatted.

This is a known issue, cc @jonasfj Somewhat related, also about surfacing supported platforms from hooks: * https://github.com/dart-lang/pub-dev/issues/8010

I'd probably use String operations instead of regexes when regexes aren't needed: `include: (d) => d.startsWith(...)`. cc @liamappelbe who recently added some convenience APIs.