Daniel Widdis
Daniel Widdis
Tests are now passing on this PR but it's failing on coverage checks for the remote model. Guess I'll add that to jacoco suppressions for now. ``` > Task :opensearch-ml-plugin:jacocoTestCoverageVerification...
This is pretty consistently failing on these tests: ``` Tests with failures: 117 tests completed, 2 failed, 14 skipped - org.opensearch.ml.rest.RestMLRAGSearchProcessorIT.testOpenAITextEmbeddingModel_ISO8859_1 - org.opensearch.ml.rest.RestMLRemoteInferenceIT.testOpenAITextEmbeddingModel_ISO8859_1 ``` These are not associated with my...
Closing in favor of #3516 which squashed and merged these commits
Having spent way too much time diving into the byte-level (or bit-level if you consider 7-bit Vints) details of these protocols, I want to make sure we're focusing on the...
@finnegancarroll This is great seeing benchmarking and deep diving into the details here! > Without trying to deconstruct the protobuf binary format one explanation could be protobuf losses some space...
Most common problem: Everyone's adding their Change log entry to the bottom of the list. That's why they conflict. Simple fix: Add your entry in numeric sorting order. If higher...
> While somewhat disruptive in the short term We can minimize the disruption by timing the switch with a minor version bump. I'm not clear from that proposal how we...
I'd be happy for someone to submit a PR to support LHM. I no longer own a Windows machine so will not be able to test it out. My guess...
@ilacc1 It looks like this could be as simple as changing appropriate WMI strings. The namespace appears to be [`"root\LibreHardwareMonitor"`](https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/blob/1118fde17d35a24db4d2df905a421454e1336e07/LibreHardwareMonitor/TestScripts/basicwmi.py#L13). Other lookup fields may be the same or similar but...
> But considering OpenHardwareMonitor is abandonware, shouldn't the default tool switch to LibreHwMonitor for everybody? Yes, likely so. I do not have access to a Windows machine any more to...