Daniel Widdis

Results 427 comments of Daniel Widdis

Some draft code by @mloufra has highlighted a few key facts: 1. The `defaultValue` and `fallbackSetting` parameters are associated with each other: when one exists, the other doesn't. - This...

This issue might be solved using a combination of Create Components (a settings object) and settings update consumers. Check on the work that has already been done.

Hey @scrawfor99 we definitely have unit tests and _view_ coverage: - jacoco runs during gradle check as part of our CI workflow and codecov creates comments on the PR -...

> Some thoughts here: OpenSearch nodes uses transport protocol and when a node dies, it gets notified instantly. We could do something similar for extensions. Definitely a good add-on, but...

Good discussion to have and I'll toss in a [link to a comment](https://github.com/opensearch-project/OpenSearch/pull/5597#discussion_r1054484606) by @reta when `WriteableSetting` was merged. TLDR: We can refactor the existing code but most of it...

I'm not sure we will need a listener for extensions: 1. For current `NodeClient` implementations such as the AD Rest implementations, they generate their own action listener that they pass...

Our initialization goes the other way right now, though. We assume all the extensions are up and running before starting OpenSearch. OS sends the init requests and right now extensions...

OSHI currently doesn't collect Memory serial numbers. You are welcome to submit a PR to add that capability, it will be similar to the recent addition of Part Number in...

Mostly just adding some debugging logging statements. 1. We start out with 3 nodes, `[node_t0, node_t1, node_t2]` 2. We find the set of non-CM nodes, `[node_t1, node_t0]` 3. We shut...

Adding a flush after the 2 nodes are randomly dropped seems effective in preventing the flakiness, but also takes a long time ```java client().admin().indices().prepareFlush().execute().actionGet(); ``` Adding a `refresh()` fails at...