Daniel Widdis

> But isn't the last snippet I've showed is making a program to use 30 GB of memory and some of those 30 GB are not present neither in virtual_memory().used...

> Sorry, this was the one with 16GB RAM + 48 GB swap, so 30 GB exceeds the RAM here and starting to use swap memory. Got it. > Would...

So a correction to my earlier comments. It does appear the Task Manager "in use" is only the physical. However, the comments about "Commit Limit" remain. So it appears Task...

> Should to separate out all the bug related fixes in one PR and then may be a separate PR for integ tests? Why?

It's somewhat normal to write a (failing) test and bug fix in the same PR. This was sitting in a mergeable state for over a week with failing tests commented...

`./gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.rest.RestMLRAGSearchProcessorIT.testBM25WithCohereUsingLlmResponseField"` is currently failing, output from the model is ```json "ext": { "retrieval_augmented_generation": { "error": "Unknown error or response." } } ```

> Yesterday test was passing in my PRs. It passes without the cohere api key change. Looks like `BM25_SEARCH_REQUEST_WITH_LLM_RESPONSE_FIELD_TEMPLATE` expects 5 strings before 3 ints, but we are sending 7...

Looks like #2246, #2250, and #2257 are related but the tests was disabled at the time (and still lis with your PR). There was a recent pull to main, probably...

I just need this commit: https://github.com/opensearch-project/ml-commons/commit/659a836775047e1d8f88a09eced7828d92e65d41

> > I just need this commit: [659a836](https://github.com/opensearch-project/ml-commons/commit/659a836775047e1d8f88a09eced7828d92e65d41) > > Backported and merged to this branch. Thanks! I was in the process of doing that on my PR branch. I'll...