Daniel Widdis

Results 395 comments of Daniel Widdis

> when the error occurs during register request execution, should the ExtensionsRunner manually `throw` an exception so `AcknowledgedResponseHandler` will handle it, or is it primarily based on the status that...

Hey @qchimera are you actively working on this? No worries if you are and need a bit more time, just let me know.

Great question. When we wrote that method we essentially made it synchronous, so it served as a natural stopping point for the initialization. It's your choice whether to rewrite it...

> I re-read it and it sounds horrible, hope you'll understand me xD Based on that disclaimer I skipped reading to independently see what needed to be done, let's see...

I'm still debugging something on #512 so don't expect it until this weekend. I suggest you do a few things: - stop using your `main` branch for features. 😁 You're...

Probably useful to integrate the solution to this with #354

Hey @Osiris34, welcome and feel free to implement this!

Hey @Osiris34 the `Extension` interface is in the `org.opensearch.sdk` package. Here's the GitHub copy: https://github.com/opensearch-project/opensearch-sdk-java/blob/main/src/main/java/org/opensearch/sdk/Extension.java

And here's the `Plugin` class to copy the default implementations from. Please change "plugin" to "extension" in the javadocs. https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/plugins/Plugin.java

> Sounds like this a general guidance from our past experience, do you think this is something we can recommend for the wider project and not just SDK? (a.k.a .github...