Darren Bolduc

Do something with Windows quickstart builds

1

I claim that the windows `quickstart-bazel`, `quickstart-cmake-*` builds don't do anything. They used to build and run a few quickstarts. We should either delete them or decide which quickstarts we...

Sample code and quickstarts should print full errors

3

Our sample/quickstart code only prints the error message, discarding the error code and error info. They look something like this (in the `StatusOr` case): https://github.com/googleapis/google-cloud-cpp/blob/08f1d4a76d92d79c8a5200a3c13e4453e8ad29a4/google/cloud/accessapproval/quickstart/quickstart.cc#L31 Printing the full error gives...

Document when `GrpcNumChannelsOption` applies

1

https://github.com/googleapis/google-cloud-cpp/blob/472f20a660310973191fcb99b7fbca81ec843a47/google/cloud/grpc_options.h#L38-L47 This option only applies in certain libraries (the handwritten ones). We should make this clear. This means documenting the option: ``` @note This option only applies to a few...

Set helpful gRPC keepalive defaults

3

Use the defaults from #9832 across all libraries. Here is an example of how we can set defaults, while respecting customer-supplied options: https://github.com/googleapis/google-cloud-cpp/blob/f779bb99395bbdfe3aac51864ff2abf2a0b6dffc/google/cloud/bigtable/internal/defaults.cc#L134-L150

Printing usage should not result in an error

5

In our [base Example class](https://github.com/googleapis/google-cloud-cpp/blob/59d7cf6a8d3b521caf304c274fc127d636d102c3/google/cloud/testing_util/example_driver.cc) and several other places printing the usage results in a shell error. This is not very important, but it seems mean to instruct users to...

- [ ] [`bigquery`](https://github.com/googleapis/google-cloud-cpp/blob/f779bb99395bbdfe3aac51864ff2abf2a0b6dffc/google/cloud/bigquery/retry_traits.h) - [ ] [`iam`](https://github.com/googleapis/google-cloud-cpp/blob/f779bb99395bbdfe3aac51864ff2abf2a0b6dffc/google/cloud/iam/retry_traits.h) - [ ] [`spanner/admin`](https://github.com/googleapis/google-cloud-cpp/blob/f779bb99395bbdfe3aac51864ff2abf2a0b6dffc/google/cloud/spanner/admin/retry_traits.h)

Deprecate and remove `bigtable::ClientOptions`

2

basically #6642, but in bigtable. With #6307 implemented, we can start to deprecate `ClientOptions`, as it is no longer needed or wanted.

Deprecate and remove `AsyncRowReader` from the public API

1

The public part of this class is just one static variable. https://github.com/googleapis/google-cloud-cpp/blob/a24af94a2e973750f5d74cdc00e967e1b8f7e78c/google/cloud/bigtable/async_row_reader.h#L47-L57 I think we should just deprecate it and point customers to `RowReader::NO_ROWS_LIMIT`. https://github.com/googleapis/google-cloud-cpp/blob/a24af94a2e973750f5d74cdc00e967e1b8f7e78c/google/cloud/bigtable/row_reader.h#L58 (The `AsyncRowReader` implementation gets moved...

Deprecate and remove public `RowReader` ctors

1

These constructors do not need to be public: https://github.com/googleapis/google-cloud-cpp/blob/a24af94a2e973750f5d74cdc00e967e1b8f7e78c/google/cloud/bigtable/row_reader.h#L60-L72 We will deprecate them and schedule their deletion date as 2023-05-01 (same as #8800)

Deprecate DataClient public member function

2

**What?:** We want to deprecate and schedule for deletion these member functions: https://github.com/googleapis/google-cloud-cpp/blob/8e9b821839901e34d9c030171afea28dd7ce96b4/google/cloud/bigtable/data_client.h#L63-L84 **Why?:** We are removing these because: * Only the client library should need this level of control...