google-cloud-cpp icon indicating copy to clipboard operation
google-cloud-cpp copied to clipboard
verified publisher icon googleapis

Deprecate and remove `AsyncRowReader` from the public API

Open dbolduc opened this issue 3 years ago • 1 comments

The public part of this class is just one static variable. https://github.com/googleapis/google-cloud-cpp/blob/a24af94a2e973750f5d74cdc00e967e1b8f7e78c/google/cloud/bigtable/async_row_reader.h#L47-L57

I think we should just deprecate it and point customers to RowReader::NO_ROWS_LIMIT. https://github.com/googleapis/google-cloud-cpp/blob/a24af94a2e973750f5d74cdc00e967e1b8f7e78c/google/cloud/bigtable/row_reader.h#L58

(The AsyncRowReader implementation gets moved into bigtable/internal/async_row_reader.h)

dbolduc avatar May 02 '22 20:05 dbolduc

These are deprecated, scheduled for removal around 2023-07.

coryan avatar Sep 14 '22 18:09 coryan