Darren Bolduc

ci(pubsublite): run integration test in more builds

2

Currently, the integration test only runs on `integration-production-pr`. Let's run it on some other linux bazel builds. - - - This change is [](https://reviewable.io/reviews/googleapis/google-cloud-cpp/9686)

cleanup(pubsublite): fix integration test resource cleanup

2

In #9678, I forgot to set `topic_name_` upon initialization, so we were not deleting the topic in the test's destructor. Oops, my bad. https://github.com/googleapis/google-cloud-cpp/blob/ad5acebb8a413baeafbb2fb9857fc2086215795e/google/cloud/pubsublite/integration_tests/publisher_integration_test.cc#L85 I noticed that most leaked topics...

refactor: simplify `*Connection` current policy getters

2

Part of the work for #9168 - - - This change is [](https://reviewable.io/reviews/googleapis/google-cloud-cpp/9673)

Consider using retry policy for OK streams with failing mutations in `bigtable::BulkApply()`

1

The current functionality is described here: https://github.com/googleapis/google-cloud-cpp/blob/b2efc81dca112d7bf9358e6db0e859da9d6195fc/google/cloud/bigtable/table.h#L418-L422 But I think that a `LimitedErrorCountRetryPolicy` of 2 should mean we only ever send 2 RPCs, regardless of whether the errors are from...

Unit test segfaults after test passes on windows

1

https://source.cloud.google.com/results/invocations/b5ebd3b1-d6a0-4ac4-8787-f6e170dec463 ``` 276/410 Test #335: spanner_internal_spanner_stub_test ...............................................***Exception: SegFault 0.35 sec Running main() from gmock_main.cc [==========] Running 2 tests from 1 test suite. [----------] Global test environment set-up. [----------] 2 tests...

* GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/2a73162a-0e6f-4b0c-962c-5efb2f6ba6cc;tab=detail?project=cloud-cpp-testing-resources * Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/83fd2b6c234ae4dd9c492d0e8328404e72949ef8/fedora-36-xsan/log-2a73162a-0e6f-4b0c-962c-5efb2f6ba6cc.txt ``` //examples:grpc_credential_types FAILED in 63.3s Running UseIdTokenHttp() example Standard exception raised: Could not contact server after 3 attempts ``` The gRPC call to generate...

Consider dropping or simplifying `ConnectionImpl::*_policy()` getters

1

We do not need the `else` branch that uses the connection's `options_` in this code: https://github.com/googleapis/google-cloud-cpp/blob/292265193edcbe6737cde4053145610a5f3e267d/google/cloud/tpu/internal/tpu_connection_impl.h#L89-L119 These policy options are defaulted in the connection, and passed back to the client....

IAM samples `GetServiceAccountKey()` key not found

11

GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/7eee7d86-f2da-4f19-9049-fdf98158cb78;tab=detail?project=cloud-cpp-testing-resources Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/96e89df122335b7205a70959917c0b1673cad22f/fedora-34-integration-daily/log-7eee7d86-f2da-4f19-9049-fdf98158cb78.txt ``` 2021-09-19T07:04:32.792477443Z [DEBUG] GetServiceAccountKey() > status=Service account key ce57700b776f38518d611e783688304e2e300166 does not exist. [NOT_FOUND] (./google/cloud/internal/log_wrapper.h:89) 2021-09-19T07:05:33.820521462Z [INFO] Enabled logging for gRPC calls (google/cloud/iam/internal/iam_stub_factory.cc:58) 2021-09-19T07:05:33.820621922Z [DEBUG] GetServiceAccountKey() >...

* GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/57f16414-f9fe-4c7d-adf6-d5bd26fc1fe9;tab=detail?project=cloud-cpp-testing-resources * Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/9617/d1e22d3c499626f863299794a1a7274a85dca516/fedora-36-integration-production/log-57f16414-f9fe-4c7d-adf6-d5bd26fc1fe9.txt Some acknowledgement ids in the request were invalid. This could be because the acknowledgement ids have expired or the acknowledgement ids were malformed. ```...

We should deprecate these classes, and emit a compiler warning when they are used. I am undecided about whether we should schedule them for deletion or not. These classes are...