Daniel Brooks comments

Results 248 comments of


                                            Daniel Brooks

font and rasterization improvements for ImGui

I gave my reasons [in a previous comment](https://github.com/CleverRaven/Cataclysm-DDA/pull/76529#issuecomment-2359977607). If you just want the health bars to make an actual column, then put them in the second column of the menu...

Implement a better way to wrap text containing color tags

Oops. Dumb mistake; I probably should have just left it until the morning when I could think more clearly.

Implement a better way to wrap text containing color tags

It does; good catch. Weirdly I've never actually seen that bug report. I wonder how many more there are that I haven’t noticed because they don’t use the correct keywords.

Implement a better way to wrap text containing color tags

Looks like a spurious build failure to me.

Implement a better way to wrap text containing color tags

Perhaps the most obvious flaw is that at certain wrap widths the first word of a segment will not be word–wrapped but instead will be split across two lines. This...

Implement a better way to wrap text containing color tags

@kevingranade, is there anything else that needs to be done before this can be merged?

Implement a better way to wrap text containing color tags

That’s weird. You can see that it is running the linker to build the executable, and that `obj/tiles/third-party/imgui/imgui.o` is listed twice.

Implement a better way to wrap text containing color tags

I cannot reproduce the problem, even with the same parameters.

Implement a better way to wrap text containing color tags

The failures are all unrelated to this particular patch.

Implement a better way to wrap text containing color tags

Nice. They’re supposed to still be there, but beneath the spell info. It worked before; perhaps I broke it when I rebased it last.