Daniel Brooks

Results 248 comments of Daniel Brooks

Fair enough :) In order to be able to pick a file, I needed a file picker. I considered the possibility of using native file pickers at first. On Windows...

> > I’m not really sure how to fix the windows build error; it needs some defines added to the list. See the Makefile changes. > ```diff > +#include >...

> This is an insanely large patch for a setting that you typically need to change only once then forget about it. I agree that most people will choose a...

If we were offering the user the choice of a custom avatar image, why would we make them jump through hoops to put the image into a particular directory? Why...

> We can use file dialogs for color presets loading, custom keybindings, maybe changing user folders. All excellent ideas :) > But judging on how much headache it caused me...

@ZhilkinSerg, could you test a small change to see if it fixes the Windows build? ```diff diff --git a/msvc-full-features/Cataclysm-common.props b/msvc-full-features/Cataclysm-common.props index be5dfb0662a8..a8e7f0875a18 100644 --- a/msvc-full-features/Cataclysm-common.props +++ b/msvc-full-features/Cataclysm-common.props @@ -66,7 +66,7...

Test failure looks unrelated; something about removing a part from a vehicle.

> D:\a\Cataclysm-DDA\Cataclysm-DDA\src\cata_imgui.cpp(238,10): fatal error C1083: Cannot open include file: 'font_picker.h': No such file or directory Uh, what?