David Yahalomi comments

Results 46 comments of


                                            David Yahalomi

Support cookie based storage for JWT's to avoid XSS

Yeah I understand completely. Thanks for your answer. I hope to get on top of this issue in the next couple of weeks. It's really a matter we cannot decide...

Support cookie based storage for JWT's to avoid XSS

Hey @veeramarni, We currently have no built in support for cookies to avoid XSS attacks. The solution we would seek IMO would be to be able to turn off storage...

Support cookie based storage for JWT's to avoid XSS

@Aetherall No you are probably right. The only thing I would as I've written here before, is a way to turn on and off cookie storage and localStorage. This way...

Support cookie based storage for JWT's to avoid XSS

You are right! This is actually quite easy to add on top of the current js-accounts implementation but should probably be part of this package as well. Excited to meet...

[discuss] Asymmetric authentication

@ozsay @pradel Can we merge this?

Graphql api context building changes

What would be a breaking change?

make pubsub subRefsMap use maps and sets

Thanks, @tjmehta @thecodeboss for the PR! and Thanks @CutmanCometh for the willingness to help.

fix: asyncIterator typescript return type

Fixed with #549 I believe? Thanks @tjmehta and let me know if I'm wrong

Race condition with simultaneous subscribe + quick unsubscribe

Fixed with #599

Fix concurrent subscribe race condition

Hey @mlaflamm Thanks for catching and fixing this! Sorry for my absence in the past months, I would like to review and merge this but I can't seem to find...