David Yahalomi comments

Results 46 comments of


                                            David Yahalomi

Fix concurrent subscribe race condition

BTW, I do think this might be able to be resolved on the using library but I think this lib should also have safety measures to such scenarios as it...

Fix concurrent subscribe race condition

Thanks everyone! Sorry again for my absence.

Fix: buffer messages from external resource

Thanks @nicomoya123 and sorry for the delay

Add an optional filterFn to PubSubAsyncIterator to workaround performance issues found in withFilter

Hey @davisg123! Thanks for the PR and sorry for my late review. I look at the example provided and I can't help but wondering why the event is even published...

Please update Readme.md with required redis ACL perms for cluster

Hey @mateodelnorte! I am not well versed in it myself. Would you care to open a PR?

feat: use @types instead of inferring from ioredis directly

Thanks @bneigher

unable to parse body when content type is multipart form data

:+1:

avatarURL does not exists

Hey @xalakox! Thanks for the PR! This whole workshop needs quite an extensive update actually... Also take a look at the commits and see that I've used commits as workshop...

Also, a friend and a great developer (@pradel) has an updated version that has steps split to directories so it's easier to update - https://github.com/pradel/graphql-workshop Hope this helps as well...

Runs outside Fiber while using inside a Meteor package

Thanks for the research @kamilkisiela! I've actually faced this issue myself in a recent project (not in a package) and have just used the `rawCollection()` function of the meteor collection...