graphql-redis-subscriptions icon indicating copy to clipboard operation
graphql-redis-subscriptions copied to clipboard

Published 20 hours ago • verified publisher icon davidyaha

fix: asyncIterator typescript return type

Open tjmehta opened this issue 5 years ago • 2 comments

I updated asyncIterator's type to include Iterable so that it can be used with for...of. Unfortunately iterall's $$asyncIterator doesn't play nice with typescript, so I had to add some ts-ignores.

tjmehta avatar Sep 08 '20 01:09 tjmehta

@tjmehta See https://github.com/apollographql/graphql-subscriptions/pull/232 I think we should push for removing iterall and using native types.

n1ru4l avatar Sep 22 '20 07:09 n1ru4l

agreed

tjmehta avatar Dec 05 '20 22:12 tjmehta

#549 I've done this, hope it will be merged...

yovanoc avatar Oct 12 '22 07:10 yovanoc

Fixed with #549 I believe? Thanks @tjmehta and let me know if I'm wrong

davidyaha avatar Dec 15 '22 19:12 davidyaha