David Pedersen

Results 309 comments of David Pedersen

> If MatchedPath was able to be mutated interiorly in the set_matched_path function in RouterService, it seems like that would work. I don't think would work. The issue is that...

> Or maybe make its extraction fallible and only succeed when match is a route, not a nested service / router? We could do that yes.

Ah I see what you mean but tbh I think that'd be very confusing. Then the value of the matched path depends on whether you access the inner `str` before...

Yes we could do that. Just needs to be clearly documented because we don't use response extensions anywhere else for user facing things. But I still think we should do...

Absolutely awesome work here @slessans. I'll try and take a look this weekend!

I thinking we could just build in special support for `WithRejection`, similarly to what we for `Path`. If we cannot find a good general solution.

> It would be nice if the error returned by `impl FromRequestParts for MatchedPath` made it clear that it failed because there's a rested router. It would give people some...

Thanks for the report! Compressing streaming response is hard and I don't know a lot about how to do it or whether it requires changes in async-compression. I don't have...

@82marbag do you wanna look into this?