David Pedersen
David Pedersen
Thats true. Having to pull in tower is unfortunate. I'm working on a proper fix.
We ended up not merging that PR https://github.com/hyperium/hyper/pull/2541
> Wouldn't [`BoxBody`](https://docs.rs/http-body/latest/http_body/combinators/struct.BoxBody.html) suffice for axum? No, I wish 😞 I want to support `impl FromRequest for Request` and also fix https://github.com/tokio-rs/axum/issues/1110. That essentially requires being able to convert an...
This was previously discussed here https://github.com/hyperium/hyper/issues/2732
I work around that like so ```rust struct DedupHyperErrorSources { error: hyper::Error, } impl DedupHyperErrorSources { fn new(error: hyper::Error) -> Self { Self { error } } } impl fmt::Debug...
> Have you confirmed that no other wrapped error has the same behavior? I looked through hyper's errors and didn't find other errors that did this. Whether there are errors...
> Having concrete Body implementations outside of hyper might be useful for abstractions (like tower-http) that do not necessarily depend on a specific version of hyper. I'd like to +1...
> From my understanding the server keeps running until all connections finish, which is normally fine, but a little problematic when we are talking about sse, since an sse connection...
> not sure if it's even possible? Not sure that it is. Hyper doesn't know anything about SSE as it's just a long running response body.
I'll close this for now. You're welcome to submit a PR that adds more logging to `ServeDir`.