David Pedersen
David Pedersen
I'm gonna close this. All this is gonna have to change anyway when we get closer to hyper 1.0 so I'd rather deal with it then. See https://github.com/tokio-rs/axum/issues/1110#issuecomment-1222265042. This PR...
Gonna mark this as a draft until https://github.com/tokio-rs/axum/pull/1086 is merged.
I think given how hard it was to review https://github.com/tokio-rs/axum/pull/1155 I'll close this and break it up into smaller PRs. Those individual PRs wont compile but I think it'll be...
> Nothing serious, but my stomach tells me to avoid exposing internal details of any kind in public environments, at least as a default. Yep I agree with that. I...
I still think its the right default. I'm certain we're gonna get so many questions about it otherwise. People don't always setup tracing to begin with. I'd accept a PR...
I've written a crate that explores strategy 2 and 3. You can find it here https://github.com/davidpdrsn/axum-extractor-config Some learnings - Doing the conversion to a custom rejection with an `async fn`...
> Have you checked whether there are any bug reports about this on rust-lang/rust? It looks more like a compiler limitation to me rather than an intentional design decision. No...
I've implemented what I posted above in https://github.com/tokio-rs/axum/pull/1256. Still not an ideal solution but better than before.
Thats cool! Adding something like that to `axum-extra` gets a 👍 from me.
Go for it! I think it should implement `Deref` and `DerefMut`, like the other extractors in axum. Afaik that guideline is generally considered not best practice anymore. I believe even...