Use more consistent icons for multimedia attachment items

[snowtimeglass]

Purpose / Description

The "Gallery" icons are inconsistent in the app.

Approach

For the "Gallery" item in Image Occlusion buttons, use the same icon with the "Gallery" icon in the "Attach multimedia content" bottom sheet.

How Has This Been Tested?

Checklist

Please, go through these checks before submitting the PR.

• [x] You have a descriptive commit message with a short title (first line, max 50 chars).
• [x] You have commented your code, particularly in hard-to-understand areas
• [x] You have performed a self-review of your own code
• [x] UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• [ ] UI Changes: You have tested your change using the Google Accessibility Scanner

[snowtimeglass]

I'm sorry. I misunderstood that there was nothing I could do about that lint error. In fact, it was possible to address it.

[david-allison]

I don't think this looks good. The icon styles are now inconsistent on the buttons in the Note Editor (filled vs outline).

I think this is better: (image - outlined) - https://fonts.google.com/icons?selected=Material+Symbols+Outlined:image:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=gallery&icon.size=24&icon.color=%23e8eaed

[snowtimeglass]

I don't think this looks good. The icon styles are now inconsistent on the buttons in the Note Editor (filled vs outline).

For a long time, I've held a similar impression toward the multimedia attachment icons:

How about using the filled icon for Camera as follows:

[david-allison]

They're still inconsistent between filled and outline

[snowtimeglass]

Are you talking mainly about the clipboard icon now? Or about the Drawing icon?

https://fonts.google.com/icons?icon.style=Filled&icon.query=content+paste&query=pen

https://fonts.google.com/icons?icon.style=Filled&icon.query=draw&query=pen

[david-allison]

The filled icons don't look good on the buttons.

Filled looks better for the bottom sheet, but draw is definitely inconsistent, others may be

[snowtimeglass]

Is this the combination you prefer? :

[david-allison]

Personally: YES!!!! that looks MUCH better!

[snowtimeglass]

Changed to the above combination.

[david-allison]

@snowtimeglass All OK here? I'm reopening as I thought this was good to go

[snowtimeglass]

Apologies for the trouble. This was a pure mistake made while deleting unnecessary branches in my "Branches" page.

[david-allison]

No worries! I've done the same

[snowtimeglass]

I see. I updated it just now. (FWIW, I filled it on the second edition of this PR, but deleted the part on the third edition due to confusion in my interpretation of what the “new external resource” means.)

[snowtimeglass]

Thank you for the clarification. I wrongly assumed the "resource" referred to the "Library": "The Material Symbols site has been used a lot, so... it's not new one."