David Allison
David Allison
This doesn't compile. I thought you said you were going to put in one PR for this change?
I misread, apologies. How many PRs is this going to be?
That's fine with me. Could you 'draft' them until they're all ready?
> > That's fine with me. Could you 'draft' them until they're all ready? > > But all the checks for the pr's will going to be failed because this...
Only seen locally (macOS): ``` After waiting for 60000 ms, the test coroutine is not completing kotlinx.coroutines.test.UncompletedCoroutinesError: After waiting for 60000 ms, the test coroutine is not completing at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTestCoroutine$3$3.invokeSuspend(TestBuilders.kt:342)...
It's only occasionally flaky. The patch provided fails with: ``` expected: but was: Expected :null Actual :Studied 0 cards in 0 minutes today ```
Needs a rebase to remove the `Sound` changes
What does this do to build times?
@mikehardy `auto-service` was added in 1a81df55fbc929750e607e5aff823b16791b0670 (https://github.com/ankidroid/Anki-Android/pull/4969) ``` compileOnly "com.google.auto.service:auto-service-annotations:1.0.1" annotationProcessor "com.google.auto.service:auto-service:1.0.1" ``` This was for ACRA. Is this still necessary as we've partially moved away from annotation-based ACRA instantiation...
Edited the comment above (sorry), still used in one case