Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Simplify HashUtil method when possible

Open Arthur-Milchior opened this issue 2 years ago • 2 comments

Now that HashUtil methods are not used in Java anymore (at least once #12301 is merged. But my two commits can be reviewed independently of #12301), I can make them return Kotlin type instead of java type. This ensure better typing as far as nullability goes.

Working on them, I also cleaned every usage of those methods that can be replaced by map/associate/filter.

I believe this PR should be rebased

Arthur-Milchior avatar Sep 04 '22 02:09 Arthur-Milchior

Needs a rebase to remove the Sound changes

david-allison avatar Sep 04 '22 02:09 david-allison

@Arthur-Milchior Build failure:

e: /Users/runner/work/Anki-Android/Anki-Android/AnkiDroid/src/main/java/com/ichi2/libanki/sched/Sched.kt: (162, 20): Unresolved reference: HashUtil

lukstbit avatar Sep 04 '22 15:09 lukstbit

Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

github-actions[bot] avatar Nov 18 '22 16:11 github-actions[bot]