Anki-Android icon indicating copy to clipboard operation
Anki-Android copied to clipboard

Fix Title to recall what gesture the window is for

Open pratyaksh1610 opened this issue 1 year ago • 4 comments

Purpose / Description

Fixed the title to recall what gesture the window is for.

Fixes

fixes #12326

pratyaksh1610 avatar Sep 05 '22 20:09 pratyaksh1610

Message to maintainers, this PR contains strings changes.

  1. Before merging this PR, it is best to run the "Sync Translations" GitHub action, then make and merge a PR from the i18n_sync branch to get translations cleaned out.
  2. Then merge this PR, and immediately do another translation PR so the huge change made by this PR's key changes are all by themselves.

Read more about updating strings on the wiki,

github-actions[bot] avatar Sep 05 '22 20:09 github-actions[bot]

Hello there. By looking at the code and based on the fact that lint fails, I assume that you haven't tested the result of your changes.

Before you push any changes you make, I'd like if you could run at least the linter (see the Development guide in the repository wiki to know how). Also, run the app, see the result of your changes on Settings > Controls, then take a screenshot and post it here.

Just ran all the tests again, found that all lint tests are passing on my machine, I think lint failed due to @SuppressLint("StringFormatInvalid")

pratyaksh1610 avatar Sep 06 '22 04:09 pratyaksh1610

Just ran all the tests again, found that all lint tests are passing on my machine, I think lint failed due to @SuppressLint("StringFormatInvalid")

It's a lint failure, not a test failure.

You can either see the output on GitHub, or run ./gradlew lintPlayDebug ktLintCheck

See: https://github.com/ankidroid/Anki-Android/wiki/Development-Guide#lint

david-allison avatar Sep 06 '22 13:09 david-allison

Also, can you please provide screenshot, so it's easy to see what it looks like

Arthur-Milchior avatar Sep 06 '22 18:09 Arthur-Milchior

The lint check still fails, please see the linked GitHub action, or run ./gradlew lint

david-allison avatar Nov 04 '22 01:11 david-allison

While it's not the main problem to solve here, generally, we try to rebase onto main, and not merge it. Don't hesitate to force push on this branch after that

Arthur-Milchior avatar Nov 04 '22 06:11 Arthur-Milchior

By the way @pratyaksh1610 , are you still working on it?

Arthur-Milchior avatar Nov 05 '22 03:11 Arthur-Milchior

By the way @pratyaksh1610 , are you still working on it?

I am working on it.

pratyaksh1610 avatar Nov 05 '22 08:11 pratyaksh1610