Antoine Poinsot
Antoine Poinsot
I plan to comment about the design on the ML, but just a note about @naumenkogs' comment above. On the contrary i think the batching feature is very compelling. The...
Are you asking about example of Miniscript descriptors? Or the specific instance i'm using?
Rebased on master to fix the macOS CI.
While rebasing this i found another crash in the `coins_view` target. Catching the exception on `AddCoin()` and continuing will cause `cachedCoinsUsage` to underflow: https://github.com/bitcoin/bitcoin/blob/4b1196a9855dcd188a24f393aa2fa21e2d61f061/src/test/fuzz/coins_view.cpp#L67-L75 https://github.com/bitcoin/bitcoin/blob/4b1196a9855dcd188a24f393aa2fa21e2d61f061/src/coins.cpp#L76-L100
Rebased on top of #29164 to fix the above.
Removed the use of a proper fix to simply abuse `Flush()` when the exception is hit to avoid the crash. See the first commit.
Status here is i'm looking into some determinism issues pointed out by Niklas: https://gnusha.org/bitcoin-core-dev/2024-06-03.log
Alright, i can't reproduce the non-determinism he observed.
@dergoegge could you have a look here when you have a sec?