Antoine Poinsot
Antoine Poinsot
I have implemented in #26567 the signed input size estimation based on descriptor rather than on a dry run of the signing logic. This would allow the wallet to estimate...
Thanks @sipa for the review and @benma for having a look. I addressed your comments in the latest push.
@instagibbs thanks for the suggestions and the examples. This functional test was clearly lacking imagination. :) However what you suggest is already thoroughly tested by the unit tests (and to...
@Sjors see https://github.com/bitcoin/bitcoin/pull/24149#discussion_r1103625462. A minimal PSBT integration is part of this PR now. We treat Miniscript-related data when we are given a PSBT. However to fill Miniscript-related data to a...
A list of dependencies would be very helpful for downstream users of this project. If this effort is undertaken, drawing a line between build-time and runtime dependencies would be nice....
Pushed a commit to accurately compute the serialized size of the witness stack size, cleanup the commits a bit, and add the newly introduced methods in the descriptors to the...
Thanks for the review. Addressed your comments and rebased on master.
Rebased, and added Miniscript support since signing support was merged.
Rebased, added more test coverage (we must be able to estimate the satisfaction size for any solvable top-level descriptor), properly integrated the `MultiSigningProvider` and removed the `MaxSatisfactionWeight` for `MiniscriptDescriptor` (which...