Antoine Poinsot

Concept ACK. Planning on reviewing soon.

cc @glozow @instagibbs @naumenkogs since you Concept ACK'd #23074. This is implementing https://github.com/bitcoin/bitcoin/pull/23074#issuecomment-1152399594.

> Do we have a preference for underestimation vs overestimation of feerates? I think it's always better to be slightly overestimate than to slightly under-estimate, as the latter can result...

Force-pushed to address @luke-jr's nit and include @glozow's great suggestion to identify CPFP from child, not parents.

Thanks everyone for the interest, finally reviving this. Rebased and modernized the code (use static casts and named parameters, make use of batched RPC calls after #26656). @naumenkogs > If...

Good point. I would have bet it's a non-trivial percentage (and an increasing one), so i wrote a quick Python script to measure this. It's [there](https://github.com/darosior/count_cpfps/blob/master/count_cpfps.py). Here is the results...

Here are the results for a few block ranges with the percentage of candidates for fee estimation among all transactions, and the percentage of CPFP among these candidates. It's around...

Rebased. --- Also optimized my script a bit and ran it over a longer period (through May and June of this year, which was marked with pretty high fees and...

> This PR is trying to ensure that the ancestors of a transaction that is assumed to be CPFP should not be recorded in the fee estimator statistics as confirmed....

Let's face it: looks like i'm not getting back to this. I think it's still a bit concerning, but hey i'm focused on other things right now and other people...