Antoine Poinsot
Antoine Poinsot
Got paged to look over the Miniscript compatibility of the scripts here. TL;DR: most scripts can be made Miniscript-compatible with only tiny modifications and without increasing their size (in fact...
I wonder if it's not cleaner to pass a new argument to `get_sources`, the revision, and `git checkout` there instead of passing commit hashes as branches.
Thanks, addressed your comments.
Rebased on master to fix the macOS CI.
Ok @DrahtBot. Done.
Added a `MakeNoLogFileContext` at init to avoid the ever-increasing memory usage due to log messages.
Concept ACK. This was hit in practice by a user in #27002. From https://github.com/bitcoin/bitcoin/issues/27002#issuecomment-1412556699: - v24.0.1: ``` $ time ./bitcoin-cli -rpcwallet=desc listunspent|grep txid|wc -l 224 real 1m15.596s user 0m0.008s sys...
Concept ACK
Concept ACK.
Rebased. There was a spurious (apparently build?) failure in the Windows CI, had to force-pushed to re-kick it.