daringli

Results 6 comments of daringli

Adds test to surface plotting for closed=True and "full torus"

> Happy to approve this once you add a test of the logger warning, which is currently tanking the code coverage percentage here. Thanks! I didn't do it since I...

Adds test to surface plotting for closed=True and "full torus"

> Is there a reason you can't use the default python warnings package instead of the logger warning? Warnings from this package can be easily tested. No reason except that...

Adds test to cover lasym=True configs in test_boozer.py, and some other untested cases.

> @daringli No action on this PR in a while. Do you think this is ready for review again? It should be ready. I just pulled in master and I'm...

(Fix-It Week) Update VMEC object to throw an error if a boundary with a different nfp is assigned

> @daringli can you take a look at this again? I just merged in master. It's ready for review if it passes the CI.

Added / fixed functionality to serialize regcoil objects with the standard simsopt.save() and simsopt.load() functions.

> @daringli Can you please update the PR? I believe it's already up-to-date with the regcoil branch. I didn't realize it would show up with the general pull requests for...

vmec_indata is not updated when updating VMEC boundary without calling set_indata()

> [@daringli](https://github.com/daringli) Can you please add the new PR # here that addresses this issue? It's #502. I've updated the main text to reflect this.