simsopt icon indicating copy to clipboard operation
simsopt copied to clipboard

Adds test to cover lasym=True configs in test_boozer.py, and some other untested cases.

Open daringli opened this issue 8 months ago • 1 comments

Unit Tests for src/simsopt/mhd/boozer.py

Adds test coverage for the if wout.lasym block (src/simsopt/mhd/boozer.py:194-199), and for the less used normalization and weight options.

The tests are merely regression tests made under the assumption that the code is correct as-is. The cases covered are rarely used in practice, and would likely go unnoticed if they break if not for the added tests.

daringli avatar May 05 '25 20:05 daringli

In addition, can you expand your description of the PR? What is the PR testing, why does it need tests, what is the coverage afterwards, etc

mishapadidar avatar May 06 '25 19:05 mishapadidar

@daringli No action on this PR in a while. Do you think this is ready for review again?

mbkumar avatar Jul 10 '25 14:07 mbkumar

@daringli No action on this PR in a while. Do you think this is ready for review again?

It should be ready. I just pulled in master and I'm waiting for the CI.

daringli avatar Aug 11 '25 12:08 daringli

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 93.00%. Comparing base (489486d) to head (ab82ca0). :warning: Report is 29 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   92.65%   93.00%   +0.35%     
==========================================
  Files          83       83              
  Lines       16194    16194              
==========================================
+ Hits        15004    15062      +58     
+ Misses       1190     1132      -58     
Flag Coverage Δ
unittests 93.00% <ø> (+0.35%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Aug 12 '25 15:08 codecov[bot]