Daraksha comments

Results 9 comments of


                                            Daraksha

Payment option doesn't update unless refresh or reopen IOU details page reported by @thesahindia

**Proposal** The payment options are set at the state and when the option paypal is removed the old value is being used https://github.com/Expensify/App/blob/62ff507162d7712c2aa76b5eb96141f83ec2dd91/src/components/SettlementButton.js#L43-L71 `key` can be used to fix this....

Payment option doesn't update unless refresh or reopen IOU details page reported by @thesahindia

The button is not updating because we are showing the previous options we need to re-render when the prop (PayPalMe address) changes On passing `key={lodashGet(this.props, 'iouReport.submitterPayPalMeAddress')}` at `SettlementButton` the button...

Payment option doesn't update unless refresh or reopen IOU details page reported by @thesahindia

> @daraksha-dk thank you for your proposal, but I don't think your solution would work, because the `SettlementButton` sets its button styles in the constructor, and the constructor isn't invoked...

A visual indicator like a tooltip should be present for currency selector reported by @daraksha-dk

**Proposal** The `CurrencySymbolButton` can be wrapped with the `Tooltip` https://github.com/Expensify/App/blob/cb93661530860f65e4aae0bc7ba7fe3c8db3e643/src/components/TextInputWithCurrencySymbol.js#L55 or it can be done at https://github.com/Expensify/App/blob/cb93661530860f65e4aae0bc7ba7fe3c8db3e643/src/components/CurrencySymbolButton.js#L17-L19 ```diff + {props.currencySymbol} + ``` we will need to add the text at...

A visual indicator like a tooltip should be present for currency selector reported by @daraksha-dk

@kavimuru I think you forgot to add `AutoAssignerTriage` tag here. Got the approval here: https://expensify.slack.com/archives/C01GTK53T8Q/p1668006728010219?thread_ts=1666716588.685909&cid=C01GTK53T8Q

A visual indicator like a tooltip should be present for currency selector reported by @daraksha-dk

I have added a [proposal](https://github.com/Expensify/App/issues/12555#issuecomment-1307517920). Please review.

A visual indicator like a tooltip should be present for currency selector reported by @daraksha-dk

PR is ready. I have added the `Moneda` as translation of `currency`. I referenced it from the line below. Please verify if it's correct. https://github.com/Expensify/App/blob/5ab92f54240381b7e2ebe78af0129d429c4d6b95/src/languages/es.js#L148

[Hold - upstream repo fix in progress] [$1000] Pressing and holding back key in a phone number field resets country selection

## Proposal ### Please re-state the problem that we are trying to solve in this issue. Pressing and holding back key in a phone number field resets country selection ###...

[Hold - upstream repo fix in progress] [$1000] Pressing and holding back key in a phone number field resets country selection

https://github.com/Expensify/App/issues/14766#issuecomment-1478784632 Based on our past experience, we should also send an email to the [dedicated CSM](mailto:[email protected]).