App
App copied to clipboard
Expensify
[Hold - upstream repo fix in progress] [$1000] Pressing and holding back key in a phone number field resets country selection
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
- Click on “Profile” avatar
- Click on “Workspace” link
- Click on “Issue cards” link
- Click on “Connect manually” link
- Fill out all forms and submit the forms leading to “Personal Information” form
- Enter personal information and click on “save & continue” button
- Click on “Passport” button
- Click on “Get secure link” button
- Click on “Get link via SMS” link
- Select a country using dropdown menu
- Enter number
- Press and hold back key
Expected Result:
Country selection should not reset
Actual Result:
Country selection resets to the default value
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android / native
- [ ] Android / Chrome
- [ ] iOS / native
- [ ] iOS / Safari
- [x] MacOS / Chrome / Safari
- [ ] MacOS / Desktop
Version Number: 1.2.91-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
https://user-images.githubusercontent.com/43996225/228334502-790fae13-ab86-4b9e-8385-d4562e314787.mp4
https://user-images.githubusercontent.com/43996225/228334524-8fa1746f-8b69-4ad6-a586-d47deceb4348.mp4
Expensify/Expensify Issue URL: Issue reported by: @Natnael-Guchima Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1680004375167929
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~016fa3b4a81adeeec1
- Upwork Job ID: 1643650089223389184
- Last Price Increase: 2023-04-19
Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
Bug0 Triage Checklist (Main S/O)
- [x] This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - [x] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- [x] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- [x] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- [x] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.
Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)
Triggered auto assignment to @Gonals (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Pressing and holding back key in a phone number field resets country selection
What is the root cause of that problem?
This also happens when the user tries to enter the 18th digit in the field. This is a UX issue at Onfido's end.
What changes do you think we should make in order to solve the problem?
As the issue is at their end, I think it should be handled there only - I've raised the issue
Proposal
Please re-state the problem that we are trying to solve in this issue.
While trying to add a bank account using the manual option, the user gets to a point where they have to enter their phone number in order to obtain a secure link. After selecting the country and entering a phone number, if the holder holds the Backspace key to delete the entry, the keyboard input eventually causes the option in the select box to reset.
What is the root cause of that problem?
This is occurring with dynamically injected code from the onfido-sdk-ui dependency.
What changes do you think we should make in order to solve the problem?
It may be possible to create a dynamic JavaScript event to intercept the keypress event for the Backspace button and cancel the default event behaviour for the select HTML element with the class name PhoneInputCountrySelect. The dynamic code is accessible in the DOM, as it's not an placed within an iframe. However, if onfido changes the dynamically generated code in the future, this will cause a regression.
What alternative solutions did you explore?
Possibly filing an issue with the onfido-sdk-ui team to fix the problem.
https://github.com/Expensify/App/issues/14766#issuecomment-1478784632 Based on our past experience, we should also send an email to the dedicated CSM.
@michaelhaxhiu I think this issue is all yours :) https://github.com/Expensify/App/issues/16640#issuecomment-1497856194
Thanks for raising the issue on onfido's repo 🙌 @daraksha-dk
@michaelhaxhiu, @Gonals, @rushatgabhane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@michaelhaxhiu, @Gonals, @rushatgabhane Whoops! This issue is 2 days overdue. Let's get this updated quick!
@michaelhaxhiu @Gonals @rushatgabhane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
@michaelhaxhiu, @Gonals, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Sorry, just catching up.
Sweet I can try reaching out to the same CSM, let me get that going and report back when its done.
I noticed that Sibtian (@allroundexperts) reached out to Onfido for another job 2 days ago. I think we may want to touch base with the CSM and discuss the future / long term agenda. I'm going to hold this for a little, so that we can speak with the contact at Onfido. I bet we can get on a call this week or early next (based on what Madhi from Onfido emailed me in the past!)
It may be better to make a shared slack channel between Expensify <> Onfido and field these kinds of requests there, as there will be more.
@MariaHCD, tagging you in on this one as I am going on parental leave! Thanks! 😁
@MariaHCD @michaelhaxhiu @rushatgabhane this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
Ok, I had the call with Onfido and need to prepare a formal SO post (so this is easily referenced). But the gist of the game plan - the best bet for Onfido bugs is to (1) make the GH in the upstream repo and (2) reach out to support, linking to the GH you made in step 1.
I emailed Onfido support, received automated response w/ subject line:
Onfido Support- Case (00150935) for Michael H has been created
@MariaHCD, @michaelhaxhiu, @rushatgabhane Eep! 4 days overdue now. Issues have feelings too...
@rushatgabhane usually I'd say No for weekly, but based on the message I just got from Onfido I agree:
Let's agree to be careful with not letting this one go. If we don't see any movement in the next ~2 weeks, I'd like to see about potentially prioritizing this in another way.
Greetings for the day!
Our team has looked into this and confirmed that it is a legitimate issue, however, with low priority.
Our team will be picking this up in the next few weeks and we will keep you posted as further progress.
In the meantime, if there is anything else we can help you with, please do let us know. Happy to help!