App
App copied to clipboard
Expensify
A visual indicator like a tooltip should be present for currency selector reported by @daraksha-dk
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Problem:
User doesn't know if he can also change the currency here by clicking on the symbol
Solution:
A visual indicator like a tooltip should be present for currency selector like we have for almost every action on the app except for this one.
Platform:
Where is this issue occurring?
- Web
- Desktop App
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL: Issue reported by: @daraksha-dk Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666716588685909
Proposal
The CurrencySymbolButton can be wrapped with the Tooltip
https://github.com/Expensify/App/blob/cb93661530860f65e4aae0bc7ba7fe3c8db3e643/src/components/TextInputWithCurrencySymbol.js#L55
or it can be done at https://github.com/Expensify/App/blob/cb93661530860f65e4aae0bc7ba7fe3c8db3e643/src/components/CurrencySymbolButton.js#L17-L19
+ <Tooltip text="currency">
<TouchableOpacity onPress={props.onCurrencyButtonPress}>
<Text style={styles.iouAmountText}>{props.currencySymbol}</Text>
</TouchableOpacity>
+ </Tooltip>
we will need to add the text at en.js and es.js we will need to use this.props.translate('') and use the key we will add and we need to use withLocalize to get this.props.translate
i don't think this problem statement was agreed by anyone. is it even a real problem?
im not a fan of the solution either, it doesn't fix for all platforms.
@kavimuru I think you forgot to add AutoAssignerTriage tag here.
Got the approval here: https://expensify.slack.com/archives/C01GTK53T8Q/p1668006728010219?thread_ts=1666716588.685909&cid=C01GTK53T8Q
@daraksha-dk New feature requests aren't a priority and won't be fixed until all/most bugs have been squashed
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!
This issue has not been updated in over 14 days. eroding to Weekly issue.
Hmm actually - I think this would be good to fix. It does feel like a bug kind of because the currency selector is pretty hard to discover and the change is very low in complexity.
Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
I agree @marcaaron
Bug0 Triage Checklist
Note: see this SO for more information.
- [x] The "bug" is actually a bug - yes, given
- [x] The bug is not a duplicate report of an existing GH.
- If it is, close the GH and add any novel details to the original GH instead
- [x] The bug is reproducible, following the reproduction steps.
- [x] The GH template is filled out as fully as possible
- The GH body and title are clear (ie. could an external contributor understand it and work on it?)
- [x] The GH was created by an Expensify employee or a QA tester
- [x] Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label
Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.
Job added to Upwork: https://www.upwork.com/jobs/~018d2593b6d75e5a34
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)
Triggered auto assignment to @dangrous (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.
Going to cc @shawnborton on this to see if we have a good design idea for this that we then can figure out how to implement!
personally, I think just solving the tooltip issue is enough for this ticket. if we are discussing different designs then that's not a "bug".
I agree, let's just add a tooltip and not change the actual design of this.
Looks like we are okay with Tooltip as a solution. @daraksha-dk's proposal here looks fine. I am not sure if the text should be currency or Change currency.
@shawnborton @dangrous ?
I think Tooltip is just for web. same concern is also apply on another platforms. And current tooltip still depends on user action (User have to move cursor above the symbol to know they can change currency by that symbol).
@dangrous this is one of the oldest issues in the /App repo. To help us clear out the large backlog of bugs, can you:
- Decide whether any proposals currently meet our guidelines and can be approved as-is
- For any that can't, please take this issue internal and treat it as one of your highest priorities
- If you have any questions, don't hesitate to start a discussion in #bug-zero
Since this is sort of a cross between a bug and a feature request, I think we're okay with moving forward with @daraksha-dk's solution for web, and we can circle back around to mobile as a future development. I'll assign you now!
📣 @daraksha-dk You have been assigned to this job by @dangrous! Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻 Keep in mind: Code of Conduct | Contributing 📖
PR is ready. I have added the Moneda as translation of currency. I referenced it from the line below. Please verify if it's correct.
https://github.com/Expensify/App/blob/5ab92f54240381b7e2ebe78af0129d429c4d6b95/src/languages/es.js#L148
Do we want the tooltip to say “Change currency”? Not sure what the Spanish translation is for that, maybe “Cambiar la moneda” but let’s get confirmation on that first
On Fri, Dec 9, 2022 at 8:52 AM Daraksha @.***> wrote:
PR is ready. I have added the Moneda as translation of currency. I referenced it from the line below. Please verify if it's correct.
https://github.com/Expensify/App/blob/5ab92f54240381b7e2ebe78af0129d429c4d6b95/src/languages/es.js#L148
— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/12555#issuecomment-1344532466, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARWH5UN3CNLAJFQF3VFNXDWMNPUVANCNFSM6AAAAAAR2PCWGQ . You are receiving this because you were mentioned.Message ID: @.***>
Do we just want to use the same selectCurrency line? Since it's already translated? I feel like that has the same meaning as Change currency