Lion - dapplion

Results 413 comments of Lion - dapplion

> why are we superstruct-ing AttestationSlashing? The change is only relevant when computing the block root. In all other codepaths the difference does not matter

> If a block request comes in and we are processing, then ignore the request > If a request for a child comes in and the parent is processing, ignore...

Hey @yootou could you provide more details on your setup? - If possible share the full command with what you are running lighthouse or all its options - What network...

We are currently debugging the logic that this issue depends on. If you don't mind @1010adigupta I'll take this one

> The reason we are using the (peer_id, root) tuple is because we want distinct peers to send us the same root to add them to current lookups right? Yes,...

> Other clients use the SSE endpoint to be informed of dependent_root changes as soon as they happen, but even if we take this approach, there will still be a...

I looked into this, all errors in `import_block` should be internal errors. The only two contentious cases: - `fork_choice.on_block`: Has some fallible cases: - `UnknownParent`: It's already checked when validating...

Note PR - https://github.com/sigp/lighthouse/pull/5655 Requires the following PR - https://github.com/sigp/lighthouse/pull/5680 or a fix to fail active requests in the sync network context upon peer disconnection

This is likely a bot, or a human very dedicated to fixing typos specifically in crypto projects