lighthouse icon indicating copy to clipboard operation
lighthouse copied to clipboard

Published 20 hours ago • verified publisher icon sigp

`superstruct` the `AttesterSlashing`

Open ethDreamer opened this issue 1 year ago • 4 comments

Issue Addressed

  • #5605

Proposed Changes

There's gonna be a lot of sub issues tied together in this branch as it's the only way we'll get this to compile..

ethDreamer avatar Apr 23 '24 22:04 ethDreamer

just a question, why are we superstruct-ing AttestationSlashing? Is it to handle some fork boundary edge case? If so, are we going to have separate fields for the base and electra variants of IndexedAttestation?

eserilev avatar Apr 25 '24 15:04 eserilev

the change in IndexedAttestation makes it necessary since slashings are included in blocks. So a deneb block needs to have the deneb IndexedAttestation and same for electra.

are we going to have separate fields for the base and electra variants of IndexedAttestation

I believe that's the plan, right @ethDreamer ?

realbigsean avatar Apr 25 '24 15:04 realbigsean

yeah I thought the plan was to use superstruct(flatten) for the IndexedAttestation so that the types would be embedded

ethDreamer avatar Apr 25 '24 16:04 ethDreamer

why are we superstruct-ing AttestationSlashing?

The change is only relevant when computing the block root. In all other codepaths the difference does not matter

dapplion avatar Apr 29 '24 02:04 dapplion