Dan King comments

Results 218 comments of


                                            Dan King

[query] add local whitening method

@tpoterba, I assigned to you in light of John C's departure.

[query] add local whitening method

It seems like this is realistically delayed until after the native compiler sprint. Is that a fair assessment, @patrick-schultz ?

[pip] Unpin python dependencies in requirements.txt files

I think I'm roughly OK with this, but maybe we should use explicit major version pins? This just feels very Wild West.

[pip] Unpin python dependencies in requirements.txt files

I'm good with this, shall we convert from draft?

[pip] Unpin python dependencies in requirements.txt files

new lint problems

[pip] Unpin python dependencies in requirements.txt files

Oh, woah, that test does look wrong. It's concerning that its suddenly failing. I'm not sure I care too much about tracking down exactly which dependency change caused this. We...

[query] Mix table stage and table value execution; delete lots of old sparky code

Should we randomly assign a compilers team member?

[query] Mix table stage and table value execution; delete lots of old sparky code

Should we close this PR, @tpoterba ?

[batch] Automatic resource price updates for GCP

I have no particular reservations. It seems to me that this change doesn't include the actual change to resources, is that right? Is there a follow up PR that will...

[batch] Automatic resource price updates for GCP

It looks like you're running `make -C docker generate-pip-lockfile` which is rewriting linux-pinned-requirements.txt, but you modified `hail/python/dev/requirements.txt` which is linked to `hail/python/dev/pinned-requirements.txt` which is regenerated by `make -C hail generate-pip-lockfile`....