hail icon indicating copy to clipboard operation
hail copied to clipboard

Published 20 hours ago • verified publisher icon hail-is

[pip] Unpin python dependencies in requirements.txt files

Open daniel-goldstein opened this issue 2 years ago • 1 comments

daniel-goldstein avatar Jun 28 '22 20:06 daniel-goldstein

I think I'm roughly OK with this, but maybe we should use explicit major version pins? This just feels very Wild West.

danking avatar Jun 30 '22 14:06 danking

I'm good with this, shall we convert from draft?

danking avatar Oct 03 '22 21:10 danking

new lint problems

danking avatar Oct 12 '22 20:10 danking

@danking Do you know what's up with this test? https://ci.hail.is/batches/5921822/jobs/68 Is the test wrong? I didn't change anything about the test in this PR so I feel like I must have somehow broken a dependency, but I'm unsure how because we don't use the google client library and I doubt it's a problem with aiohttp.

daniel-goldstein avatar Oct 12 '22 21:10 daniel-goldstein

Oh, woah, that test does look wrong. It's concerning that its suddenly failing.

I'm not sure I care too much about tracking down exactly which dependency change caused this. We should fix the test obviously. We should add a test that verifies both ?a and ? have the expected data (in particular, that we didn't overwrite one with the other!).

danking avatar Oct 12 '22 23:10 danking

Heh, so turns out that test_weird_urls is missing the @pytest.mark.asyncio decorator, and so it was getting skipped with a warning this whole time. The pytest upgrade added auto-detection of async tests and so it ran this broken test for the first time. I'm PR'ing to treat most warnings as errors in #12322.

daniel-goldstein avatar Oct 13 '22 21:10 daniel-goldstein