Dan King comments

Results 218 comments of


                                            Dan King

BUG: Arrow Binary View Types Don't Print When containing missing values

If you just want a quick fix: ```python import pandas as pd import pyarrow as pa old_ArrowDtype_type = pd.ArrowDtype.type @property def ArrowDtype_type(self): if pa.types.is_string_view(self.pyarrow_dtype): return str return old_ArrowDtype_type(self) pd.ArrowDtype.type =...

Building sdist fails if a crate in workspace isn't used

I think we're encountering a similar issue in vortex (https://github.com/spiraldb/vortex). We have a Rust workspace with several crates. Suppose, for example, that we have three crates: a, b, and python....

Building sdist fails if a crate in workspace isn't used

Hey @messense ! Thanks for the rapid reply! Yes, this branch fails: ``` git clone [email protected]:spiraldb/vortex.git --branch dk/python-publish ``` I failed to produce a simple example, so it might be...

Building sdist fails if a crate in workspace isn't used

Thanks! Indeed, this change makes the sdist buildable (indeed, vortex-proto is present in the sdist). I'm a bit confused though. I still don't see vortex-proto listed in the dependencies (I...

Building sdist fails if a crate in workspace isn't used

Amazing! Thank you kindly @messense!

Layout readers do not handle projections with repeated columns

We actually support this now.

ResourceGroup issues modelling writing a bgzipped file and its TBI index via `write_output`

Sorry this got dropped @jmarshall , I'll bring it up for discussion on our Monday planning meeting.

[ci] Fix pre-commit hook generator to match what CI does

Ah, I've been running into this as well and didn't know why. Testing all the hooks seems reasonable.

[batch] instances leaked by PR 13509 and 13458

Are you asking how to detect that one command of many in a bash *pipeline* failed? We need pipe fail enabled for that: ```bash # bad (base) dking@wm28c-761 ~ %...

[batch] instances leaked by PR 13509 and 13458

That said, I think the `set +e` is intentional: we want to try to delete every instance even if one fails. What we should actually do is loop over all...