Daniel Suh
Daniel Suh
I'd like to take this issue if possible, I feel pretty comfortable in the D2 repo now.
So you want something like this? ``` x: hello { link: https://github.com { icon: https://github.com/_____.svg } } ```
> Thanks for this fix @danielsuh05! > > Would you be open to add a test for this case of deactivated accounts here: > > https://github.com/mattermost/mattermost/blob/65f7a623ce424051871346447745912dde146e84/server/channels/app/team_test.go#L1447 > ? Yes, of...
> @danielsuh05 Looks like you need to run `make i18n-extract` Thanks! I just ran it in `server/` but it seems like it deleted a bunch of the other translations in...
Sorry, a bit confused about what #12 is asking for. Does it mean add the ability for D2 to add an icon along a path? For example, there would be...
Ok, just before I start to tackle the issue, just want to make sure everything is in-line with your thinking. Ignoring animation for now, to close issue #12, I need...
Oh I see what you mean. I was trying to figure out how exactly you wanted it implemented so I decided to do this for now and get a review....
Was this more what you were thinking?
I'm ok continuing with this issue.