d2 icon indicating copy to clipboard operation
d2 copied to clipboard
verified publisher icon terrastruct

feature: supports link on connections

Open danielsuh05 opened this issue 1 year ago • 7 comments

Connections now support link: (fixes issue #1827)

Some notes:

  • Every single test file changed because all of the class names changed when adding link: "".
  • Links don't work yet on connections in PDFs, not sure exactly how to do that.
  • Check link-on-connections for the test I used.

danielsuh05 avatar May 29 '24 02:05 danielsuh05

Oh I see what you mean. I was trying to figure out how exactly you wanted it implemented so I decided to do this for now and get a review. I'll work on it

danielsuh05 avatar May 29 '24 20:05 danielsuh05

Was this more what you were thinking?

danielsuh05 avatar May 30 '24 01:05 danielsuh05

Hi, what's the status on this PR?

huyz avatar Sep 02 '24 13:09 huyz

Oops I did not realize the ball was in my court for reviewing. Sorry @danielsuh05 . I'm not sure if you've moved on. No worries if so I can take over, otherwise will leave a review ASAP

alixander avatar Sep 02 '24 17:09 alixander

I hope to see this soon. Links on connections are pretty important. They open up a lot of possibilities for letting diagrams act as jump points to, e.g., code.

huyz avatar Sep 05 '24 09:09 huyz

I'm ok continuing with this issue.

danielsuh05 avatar Sep 06 '24 03:09 danielsuh05

Thank you @danielsuh05 and @alixander!

huyz avatar Sep 06 '24 03:09 huyz

@danielsuh05 Let me know if you'd like me to take over

alixander avatar Nov 17 '24 23:11 alixander

is the font color blue only?

bo-ku-ra avatar Feb 05 '25 05:02 bo-ku-ra

yes, since that's the universal link color. But if you want it different, please make an issue

alixander avatar Feb 05 '25 17:02 alixander