d2 icon indicating copy to clipboard operation
d2 copied to clipboard

Combining circle shape for arrowheads with sketch mode removes all arrowheads

Open ddolan-lutron opened this issue 1 year ago • 6 comments

See this playground.

Setting the arrowhead shape for either source or target arrowheads to circle causes all arrowheads to be omitted from the diagram when Sketch Mode is used. Seems to be independent of other arrowhead properties.

ddolan-lutron avatar May 10 '24 18:05 ddolan-lutron

Hi! @alixander I am sossost, a new contributor. I would like to solve this issue. Could you assign it for me?

sossost avatar May 11 '24 02:05 sossost

Much appreciated @sossost !

See relevant starting tip here: https://github.com/terrastruct/d2/issues/1936#issuecomment-2103037590

alixander avatar May 11 '24 17:05 alixander

@alixander hello. I tried this issue because it seemed interesting, but it was too difficult due to my lack of understanding of the Go language. Can I give someone else a chance?? sorry.

sossost avatar May 16 '24 11:05 sossost

No worries @sossost , thanks for trying!

alixander avatar May 16 '24 11:05 alixander

maybe i'm looking in the wrong place, but...

sketch.go (func ArrowheadJS) case d2target.CircleArrowhead: and case d2target.FilledCircleArrowhead: are missing?

bo-ku-ra avatar May 16 '24 14:05 bo-ku-ra

I'd like to take this issue if possible, I feel pretty comfortable in the D2 repo now.

danielsuh05 avatar May 17 '24 01:05 danielsuh05