Daniel Morrison

Results 27 comments of Daniel Morrison

I just ran into this, and this gets it bundling again. Rails 6 needs thor 1.0.

@Rambou I've volunteered to get this merged and updated, though it'll be a few days before I have time to finish that up. In the meantime, pointing at @Deekor's branch...

> Does someone know how to silence `hound`? This is annoying... Add an exclude to `.scss-lint.yml` for the compiled files.

I'm intrigued by all, but here are some comments: > 1. Is it possible to off-load all of the audit table processes to background jobs with Resque/Sidekiq? I'm open to...

One downside seems to be that you could no longer restore a record to its original state (with original id). That isn't a design goal of Audited, but I do...

Don't take my slow response as anything other than a slow response. ;) I probably won't have time to dig in until Monday or so.

@darronschall [Rack 3.0.0](https://github.com/rack/rack/blob/main/UPGRADE-GUIDE.md) came out and that's likely what's causing the test errors.

Adding `require 'rack'` (or just `require 'rack/request'`) to the top of `lib/twirp/service.rb` fixes the test errors in Rack 3. Outside the scope of this PR, but `rack` is listed is...

I think this should be built-in. PRs very welcome.

Looks good to me after a quick glance. Should we add any deprecation methods/warnings?