Daniel Morrison

Results 30 comments of Daniel Morrison

@arthurnn any chance we can get some eyes on this? It continues to be an annoyance for us. Happy to assist with review and/or maintenance if it'd help.

To clarify the problem again, when I have a service that ends in `Service`, it ends up duplicating the word Service in my `_twirp.rb` generated file: ``` service MessagesService {...

I like it. A couple things: We test migrations in `test/upgrade_generator_test.rb` and should do that here too. I'm confused why you made the test changes. I see that it fails...

Deleted unhelpful comment.

Deleted unhelpful comment.

Cool, i'll take a look deeper later in the week if nobody else does first. One thing we'll need to add is another migration for existing users.

@arthurnn I appreciate the renewed commitment. At @collectiveidea, we use this pretty heavily. I poke at our two outstanding issues. #97 was originally part of a PR that broke some...

I like the idea here, but I'd like to see some tests exercising it. Also, we changed `audit_class=` to allow a constant or string (to avoid autoload issues).

I [merged an update](https://github.com/collectiveidea/audited/pull/609) that expects a string instead of a class to`config.audit_class` I believe that will solve this issue.

I was poking at this on Heroku yesterday too and gave up.